Skip to content

Commit

Permalink
Rollup merge of #110948 - TimNN:patch-1, r=WaffleLapkin
Browse files Browse the repository at this point in the history
run-make test: using single quotes to not trigger the shell

This test got added in #110801.

I'm no expert on Makefiles, but IIUC this command is passed to the shell, which usually tries to execute commands specified in between backticks in double-quoted strings.

Using single quotes should fix this, I think. (Note: Waiting for CI to test this, since I only have a web browser available right now).

r? ``@jyn514``

cc ``@WaffleLapkin``

Since this is breaking our build bot, even if it is not directly LLVM related: ``@rustbot`` label: +llvm-main
  • Loading branch information
matthiaskrgr authored Apr 28, 2023
2 parents 03da9db + f1b88ea commit afbb188
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/run-make/inaccessible-temp-dir/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ all:
# Run rustc with `-Ztemps-dir` set to a directory
# *inside* the inaccessible one, so that it can't create it
$(RUSTC) program.rs -Ztemps-dir=$(TMPDIR)/inaccessible/tmp 2>&1 \
| $(CGREP) "failed to find or create the directory specified by `--temps-dir`"
| $(CGREP) 'failed to find or create the directory specified by `--temps-dir`'

# Make the inaccessible directory accessible,
# so that compiletest can delete the temp dir
Expand Down

0 comments on commit afbb188

Please sign in to comment.