Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect link for BufWriter on std::fs::File page #125066

Closed
johnbchron opened this issue May 13, 2024 · 2 comments
Closed

Incorrect link for BufWriter on std::fs::File page #125066

johnbchron opened this issue May 13, 2024 · 2 comments
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@johnbchron
Copy link

Location

In the description of std::fs::File, the first mention of BufWriter:

For efficiency, consider wrapping the file in a BufReader or BufWriter...

Summary

The BufWriter link points to BufReader. I checked the source and the destination is not explicit, so I'm not sure what's going on here. Could be a rustdoc bug.
@johnbchron johnbchron added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label May 13, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 13, 2024
@tbu-
Copy link
Contributor

tbu- commented May 13, 2024 •
edited
Loading

Fixed by #123086 already. Will be fixed in the link you provided once 1.79 hits stable, which is on 2024-06-13 UTC.

@jieyouxu jieyouxu added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 13, 2024
@jieyouxu
Copy link
Member

Closing as there's already a fix implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tbu- @johnbchron @jieyouxu @rustbot