Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tidy output on Travis is hard to read #21322

Closed
pshc opened this issue Jan 17, 2015 · 3 comments
Closed

make tidy output on Travis is hard to read #21322

pshc opened this issue Jan 17, 2015 · 3 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@pshc
Copy link
Contributor

pshc commented Jan 17, 2015

The output chock is full of NOTEs, which distract the eye from the actual problem. example

I'm guessing that these NOTEs aren't really useful in Travis test builds? Would it make sense to remove them?

Potential alternate solution is to highlight the failures in red: #18826
@kmcallister kmcallister added A-testsuite Area: The testsuite used to check the correctness of rustc I-papercut E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Jan 17, 2015
@iKevinY
Copy link
Contributor

iKevinY commented Jan 18, 2015

It seems logical enough to ignore NOTEs on Travis builds, so I took a shot at it in #21369.

@iKevinY
Copy link
Contributor

iKevinY commented Jan 21, 2015

I think this issue is closable now that #21369 has been merged in.

@pshc
Copy link
Contributor Author

pshc commented Jan 21, 2015

Awesome, thanks for the quick fix!

@pshc pshc closed this as completed Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pshc @kmcallister @iKevinY