Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error index tests are not run during make check #31587

Closed
brson opened this issue Feb 11, 2016 · 4 comments
Closed

error index tests are not run during make check #31587

brson opened this issue Feb 11, 2016 · 4 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Feb 11, 2016

#30726 adds testing of the error index. They run on make check-docs but not yet on make check. They should.

This is just a matter of deciphering tests.mk and figuring the right rule to add.

@brson brson added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-testsuite Area: The testsuite used to check the correctness of rustc labels Feb 11, 2016
@GuillaumeGomez
Copy link
Member

I don't think anything Makefile related should be labelled as easy.

@james-w
Copy link

james-w commented Feb 15, 2016

I will take a look at this. I'm pretty experienced with Makefiles, and I've had a look and
I think I follow how this works.

@apasel422
Copy link
Contributor

This would likely have prevented #33662.

@dsprenkels
Copy link
Contributor

This issue has been fixed by #34201 and may be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

5 participants