Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rust-docs package optional, not installed by default #36970

Closed
brson opened this issue Oct 4, 2016 · 6 comments
Closed

Make rust-docs package optional, not installed by default #36970

brson opened this issue Oct 4, 2016 · 6 comments

Comments

@brson
Copy link
Contributor

brson commented Oct 4, 2016

Today the rust-docs package is a required component. Now that rustup supports component installation it can be made optional. This change needs to be done in rust-buildbot.

@durka
Copy link
Contributor

durka commented Oct 5, 2016

I think it should still be default. Nobody wants to discover at the airport that they should have included just one more rustup incantation.

@nagisa
Copy link
Member

nagisa commented Oct 5, 2016

Very duplicate-ish of #24117

@nagisa
Copy link
Member

nagisa commented Oct 5, 2016

@brson why exactly changing defaults in rustup is not enough? Doesn’t it already download the separate packages? It seems to me like it should be as easy as flipping a boolean somewhere in rustup.

@Mark-Simulacrum
Copy link
Member

Making the docs component optional, but still installed by default seems like the way to go forward here; that should avoid the missing docs at airport problem, but still allow those who don't want docs to not have to download them.

@japaric
Copy link
Member

japaric commented Nov 18, 2016

@alexcrichton
Copy link
Member

This was done, and then undone, so I'm going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants