Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save used-trait-import sets to the incremental state and invalidate when reloading if deps have changed #39496

Closed
nikomatsakis opened this issue Feb 3, 2017 · 1 comment
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Feb 3, 2017

Background: See the general plan for skipping typeck. Part of the roadmap issue on incremental compilation.

Once #39495 is done, we need to save the contents of the used_trait_imports map to the incremental state. Since the values are basically just def-ids, we have all the necessary infrastructure. When re-loading, if we find that a UsedTraitImport(X) node has been marked as dirty, we will remove the corresponding value from the map. For the clean values, we can reload their entries and store them into the map.

@nikomatsakis nikomatsakis added A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 3, 2017
@nikomatsakis
Copy link
Contributor Author

Closing this, as we've been adjusting plan and I no longer this this is a logical next step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

1 participant