Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap return values of pipes::init() #4501

Closed
nickdesaulniers opened this issue Jan 16, 2013 · 3 comments
Closed

Swap return values of pipes::init() #4501

nickdesaulniers opened this issue Jan 16, 2013 · 3 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@nickdesaulniers
Copy link

This is a continuation of sorts of Issue #4496. In that issue, the return values of the tuple returned from calling pipes::init() were changes from (channel, port) to (port, channel) to better conform with other calling conventions elsewhere in the code base. I noticed that pipes::init() also went against convention, but don't yet have the understanding of self hosting compiler issues to tackle this just yet. A read through Issue #4496 is recommended.
ack --type-add=rust=.rs,.rc oneshot::init

@nickdesaulniers
Copy link
Author

Assign=me

@nikomatsakis
Copy link
Contributor

Not critical for 0.6; removing milestone

@nickdesaulniers
Copy link
Author

Looks like the definition of oneshot::init was moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

2 participants