Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-trait documentation section empty with manual auto-trait impls #48606

Closed
RalfJung opened this issue Feb 28, 2018 · 1 comment
Closed

Auto-trait documentation section empty with manual auto-trait impls #48606

RalfJung opened this issue Feb 28, 2018 · 1 comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@RalfJung
Copy link
Member

With #47833 merged, I expected to see auto-trait implementations in the nightly docs in a separate section. However, in case there are manual impls, they are still shown in the "Trait Implementations" section. For example, https://doc.rust-lang.org/nightly/std/cell/struct.Cell.html has the impls for Send and !Sync in the "Trait Implementations" section, leaving the "Auto Trait Implementations" section entirely empty.

At the very least, this looks funny and probably the section header should not be shown if the section is empty. However, I actually think it'd make more sense to move manual impls of auto-traits into that section -- this way, the place to look for Send and Sync impls is always the same, instead of depending on the type like it does now.

@estebank estebank added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Feb 28, 2018
@XAMPPRocky XAMPPRocky added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label May 14, 2018
@GuillaumeGomez
Copy link
Member

I don't see this bug anymore so I'll close the issue. Don't hesitate to reopen it if you find it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

4 participants