Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustc should warn if you have a stability attribute on a non-public item #83380

Open
jyn514 opened this issue Mar 22, 2021 · 3 comments
Open

Rustc should warn if you have a stability attribute on a non-public item #83380

jyn514 opened this issue Mar 22, 2021 · 3 comments
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-stability Area: `#[stable]`, `#[unstable]` etc. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Mar 22, 2021 •
edited by rustbot
Loading

Originally posted by @ijackson in #83372 (comment)
@jyn514 jyn514 added A-stability Area: `#[stable]`, `#[unstable]` etc. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels Mar 22, 2021
This was referenced Mar 23, 2021
Closed
Closed
@camelid camelid self-assigned this Mar 23, 2021
@jhpratt
Copy link
Member

jhpratt commented Nov 14, 2021

For const fn this is sometimes necessary.

@camelid camelid removed their assignment Nov 17, 2021
@camelid
Copy link
Member

camelid commented Nov 17, 2021

I'm not sure why this change doesn't work correctly, and I probably won't be able to look into it soon, so releasing assignment for now. I may try again in the future if someone else doesn't do it by then.

@gimbling-away
Copy link
Contributor

@rustbot claim

@gimbling-away gimbling-away removed their assignment Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-stability Area: `#[stable]`, `#[unstable]` etc. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error on private items with stability attributes camelid/rust
4 participants
@jhpratt @jyn514 @camelid @gimbling-away