Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge CrateDisambiguator into StableCrateId #85795

Closed
bjorn3 opened this issue May 28, 2021 · 0 comments · Fixed by #85804
Closed

Merge CrateDisambiguator into StableCrateId #85795

bjorn3 opened this issue May 28, 2021 · 0 comments · Fixed by #85804
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@bjorn3
Copy link
Member

bjorn3 commented May 28, 2021

StableCrateId is derived from CrateDisambiguator and the crate name. CrateDisambiguator alone is likely never what you need as it only depends on -Cmetadata and --crate-type and as such can easily be the same for different crates when not using cargo.
@bjorn3 bjorn3 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 28, 2021
@bjorn3 bjorn3 mentioned this issue May 29, 2021
Merged
@bors bors closed this as completed in 5957990 May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge CrateDisambiguator into StableCrateId bjorn3/rust
1 participant
@bjorn3