Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improper_ctypes lint should cover "C" abi function pointer types. #95683

Closed
crlf0710 opened this issue Apr 5, 2022 · 0 comments · Fixed by #130669
Closed

improper_ctypes lint should cover "C" abi function pointer types. #95683

crlf0710 opened this issue Apr 5, 2022 · 0 comments · Fixed by #130669
Labels
A-FFI Area: Foreign function interface (FFI) A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug. L-improper_ctypes_definitions Lint: improper_ctypes_definitions T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@crlf0710
Copy link
Member

crlf0710 commented Apr 5, 2022

I tried this code:

pub type F = extern "C" fn(&[u8]);

I expected to see this happen: improper_ctypes should trigger for this definition.

Instead, this happened: It is not linted.
@crlf0710 crlf0710 added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-FFI Area: Foreign function interface (FFI) labels Apr 5, 2022
@workingjubilee workingjubilee added A-ABI Area: Concerning the application binary interface (ABI) and removed A-ABI Area: Concerning the application binary interface (ABI) labels Jul 1, 2022
@workingjubilee workingjubilee mentioned this issue Oct 19, 2023
Open
@jieyouxu jieyouxu added the L-improper_ctypes Lint: improper_ctypes label May 13, 2024
@workingjubilee workingjubilee mentioned this issue Sep 21, 2024
Merged
@jieyouxu jieyouxu added L-improper_ctypes_definitions Lint: improper_ctypes_definitions and removed L-improper_ctypes Lint: improper_ctypes labels Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-FFI Area: Foreign function interface (FFI) A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug. L-improper_ctypes_definitions Lint: improper_ctypes_definitions T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: Test that extern "C" fn ptrs lint on slices workingjubilee/rustc
3 participants
@crlf0710 @jieyouxu @workingjubilee