Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiletest: only take a --python argument and remove the --lldb-python / --docck-python args #96011

Closed
jyn514 opened this issue Apr 13, 2022 · 1 comment · Fixed by #96237
Closed
Assignees
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Apr 13, 2022

Compiletest currently has two different arguments telling it which python to use. Since #95441, both are always the same. We should change it to just one --python argument to simplify things.

Mentoring instructions: Change

.reqopt("", "lldb-python", "path to python to use for doc tests", "PATH")
.reqopt("", "docck-python", "path to python to use for doc tests", "PATH")

to be a single python argument, then change

rust/src/bootstrap/test.rs

Lines 1403 to 1405 in f38c5c8

cmd.arg("--docck-python").arg(builder.python());
cmd.arg("--lldb-python").arg(builder.python());
to use the updated arguments.

@AlecGoncharow are you interested in tackling this one too? :)

@rustbot label +A-rustbuild +A-testsuite +E-easy +E-mentor

Originally posted by @jyn514 in #95441 (comment)

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Apr 13, 2022
@AlecGoncharow
Copy link
Contributor

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants