-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust 1.60.0 fails to build on Solaris #96054
Comments
I'm assuming this used to build in 1.59, right? |
The released 1.60.0 source tarball is missing the third-party/benchmarks contents or the cmake configuration to not require it, I don't think this is Solaris-specific. See llvm/llvm-project#54941 This is a new regression in rust 1.60.0. You can work around this by changing |
Version 1.59 was ok. And I can confirm the workaround with LLVM_INCLUDE_BENCHMARKS. |
We do set Line 204 in e2661ba
And working build from src distribution is checked by So there must be something more missing here. Can you please provide a more complete log? I'm wondering if this might not be during the build of LLVM, but rather some other LLVM subproject like LLD, which might not be setting the cmake option. Edit: I checked that distcheck with lld works fine, so that's not it. |
|
Looks like this is due to some kind of "NATIVE" cross-compile that runs as part of the build (https://github.com/llvm/llvm-project/blob/12f55cac69d8978d1c433756a8b2114bf9ed1e1b/llvm/CMakeLists.txt#L1027) and which does not set |
Good analysis-- passing it through in
|
Assigning priority as discussed in the Zulip thread of the Prioritization Working Group. @gco: can @nikic 's suggestion be turned into a patch to fix the issue or in your opinion there is more to do to fix this? @rustbot label -I-prioritize +P-high |
There's a literal patch for that in my previous comment. However, I tracked down why a native build is considered a "cross compilation"-- The cmake crate adds |
Discussed at P-high review meeting We believe this is probably resolved by rust-lang/cmake-rs#158 If it isn't resolved by that PR, then please do re-open this issue so we know about it. |
It fails with following error:
The text was updated successfully, but these errors were encountered: