From 1805e5fb487fb3d1e6b8dc71b3983ac91b62c511 Mon Sep 17 00:00:00 2001 From: Amanieu d'Antras Date: Tue, 3 Nov 2015 15:19:46 +0000 Subject: [PATCH 1/2] Allow indirect operands to be used as inputs for inline asm --- src/libsyntax/ext/asm.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsyntax/ext/asm.rs b/src/libsyntax/ext/asm.rs index 984e73f85f610..bdfbb7a49330e 100644 --- a/src/libsyntax/ext/asm.rs +++ b/src/libsyntax/ext/asm.rs @@ -139,9 +139,9 @@ pub fn expand_asm<'cx>(cx: &'cx mut ExtCtxt, sp: Span, tts: &[ast::TokenTree]) let (constraint, _str_style) = panictry!(p.parse_str()); - if constraint.starts_with("=") { + if constraint.starts_with("=") && !constraint.contains("*") { cx.span_err(p.last_span, "input operand constraint contains '='"); - } else if constraint.starts_with("+") { + } else if constraint.starts_with("+") && !constraint.contains("*") { cx.span_err(p.last_span, "input operand constraint contains '+'"); } From 59c5191c211711c8f51daa4911b1b734393a4011 Mon Sep 17 00:00:00 2001 From: Amanieu d'Antras Date: Tue, 3 Nov 2015 18:13:03 +0000 Subject: [PATCH 2/2] Add test for inline asm indirect memory operands --- src/test/run-pass/asm-indirect-memory.rs | 39 ++++++++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 src/test/run-pass/asm-indirect-memory.rs diff --git a/src/test/run-pass/asm-indirect-memory.rs b/src/test/run-pass/asm-indirect-memory.rs new file mode 100644 index 0000000000000..80fd548dfe354 --- /dev/null +++ b/src/test/run-pass/asm-indirect-memory.rs @@ -0,0 +1,39 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![feature(asm)] + +#[cfg(any(target_arch = "x86", target_arch = "x86_64"))] +fn read(ptr: &u32) -> u32 { + let out: u32; + unsafe { + asm!("mov $1, $0" : "=r" (out) : "*m" (ptr)); + } + out +} + +#[cfg(any(target_arch = "x86", target_arch = "x86_64"))] +fn write(ptr: &mut u32, val: u32) { + unsafe { + asm!("mov $1, $0" :: "=*m" (ptr), "r" (val)); + } +} + +#[cfg(any(target_arch = "x86", target_arch = "x86_64"))] +pub fn main() { + let a = 1; + let mut b = 2; + assert_eq!(read(&a), 1); + write(&mut b, 3); + assert_eq!(b, 3); +} + +#[cfg(not(any(target_arch = "x86", target_arch = "x86_64")))] +pub fn main() {}