diff --git a/src/librustc/dep_graph/graph.rs b/src/librustc/dep_graph/graph.rs index 33902fe913a9c..a37a7e760d82b 100644 --- a/src/librustc/dep_graph/graph.rs +++ b/src/librustc/dep_graph/graph.rs @@ -350,12 +350,7 @@ impl DepGraph { { if let Some(ref data) = self.data { let (result, task_deps) = ty::tls::with_context(|icx| { - let task_deps = Lock::new(TaskDeps { - #[cfg(debug_assertions)] - node: None, - reads: SmallVec::new(), - read_set: Default::default(), - }); + let task_deps = Lock::new(TaskDeps::default()); let r = { let icx = ty::tls::ImplicitCtxt { task_deps: Some(&task_deps), ..icx.clone() }; @@ -968,7 +963,7 @@ pub enum WorkProductFileKind { #[derive(Clone)] struct DepNodeData { node: DepNode, - edges: SmallVec<[DepNodeIndex; 8]>, + edges: EdgesVec, fingerprint: Fingerprint, } @@ -1093,7 +1088,7 @@ impl CurrentDepGraph { fn alloc_node( &self, dep_node: DepNode, - edges: SmallVec<[DepNodeIndex; 8]>, + edges: EdgesVec, fingerprint: Fingerprint, ) -> DepNodeIndex { debug_assert!( @@ -1105,7 +1100,7 @@ impl CurrentDepGraph { fn intern_node( &self, dep_node: DepNode, - edges: SmallVec<[DepNodeIndex; 8]>, + edges: EdgesVec, fingerprint: Fingerprint, ) -> DepNodeIndex { match self.node_to_node_index.get_shard_by_value(&dep_node).lock().entry(dep_node) { @@ -1128,11 +1123,25 @@ impl DepGraphData { let icx = if let Some(icx) = icx { icx } else { return }; if let Some(task_deps) = icx.task_deps { let mut task_deps = task_deps.lock(); + let task_deps = &mut *task_deps; if cfg!(debug_assertions) { self.current.total_read_count.fetch_add(1, Relaxed); } - if task_deps.read_set.insert(source) { + + // As long as we only have a low number of reads we can avoid doing a hash + // insert and potentially allocating/reallocating the hashmap + let new_read = if task_deps.reads.len() < TASK_DEPS_READS_CAP { + task_deps.reads.iter().all(|other| *other != source) + } else { + task_deps.read_set.insert(source) + }; + if new_read { task_deps.reads.push(source); + if task_deps.reads.len() == TASK_DEPS_READS_CAP { + // Fill `read_set` with what we have so far so we can use the hashset next + // time + task_deps.read_set.extend(task_deps.reads.iter().copied()); + } #[cfg(debug_assertions)] { @@ -1154,10 +1163,14 @@ impl DepGraphData { } } +/// The capacity of the `reads` field `SmallVec` +const TASK_DEPS_READS_CAP: usize = 8; +type EdgesVec = SmallVec<[DepNodeIndex; TASK_DEPS_READS_CAP]>; +#[derive(Default)] pub struct TaskDeps { #[cfg(debug_assertions)] node: Option, - reads: SmallVec<[DepNodeIndex; 8]>, + reads: EdgesVec, read_set: FxHashSet, }