From 597f889e45e3a76b1f5fc22f30ab499490e91862 Mon Sep 17 00:00:00 2001 From: Josh Triplett Date: Mon, 1 Nov 2021 15:34:19 +0100 Subject: [PATCH 1/2] Clarify what to do with accepted feature gates The documentation only referenced `removed.rs`, but feature gates for accepted features move to `accepted.rs`. --- compiler/rustc_feature/src/active.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/compiler/rustc_feature/src/active.rs b/compiler/rustc_feature/src/active.rs index 2bbfb561ba594..7cf53d40ff693 100644 --- a/compiler/rustc_feature/src/active.rs +++ b/compiler/rustc_feature/src/active.rs @@ -103,7 +103,8 @@ impl Feature { // If you change this, please modify `src/doc/unstable-book` as well. // -// Don't ever remove anything from this list; move them to `removed.rs`. +// Don't ever remove anything from this list; move them to `accepted.rs` if +// accepted or `removed.rs` if removed. // // The version numbers here correspond to the version in which the current status // was set. This is most important for knowing when a particular feature became From eb23a7333ff540adac206c80f2416a69e25c924d Mon Sep 17 00:00:00 2001 From: Josh Triplett Date: Tue, 2 Nov 2021 15:30:28 +0100 Subject: [PATCH 2/2] Add link to documentation about feature gates --- compiler/rustc_feature/src/active.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/compiler/rustc_feature/src/active.rs b/compiler/rustc_feature/src/active.rs index 7cf53d40ff693..a55ea31481074 100644 --- a/compiler/rustc_feature/src/active.rs +++ b/compiler/rustc_feature/src/active.rs @@ -101,6 +101,9 @@ impl Feature { } } +// See https://rustc-dev-guide.rust-lang.org/feature-gates.html#feature-gates for more +// documentation about handling feature gates. +// // If you change this, please modify `src/doc/unstable-book` as well. // // Don't ever remove anything from this list; move them to `accepted.rs` if