Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfg(bootstrap) docs don't say what it does #1255

Closed
camelid opened this issue Nov 10, 2021 · 2 comments · Fixed by #1669
Closed

cfg(bootstrap) docs don't say what it does #1255

camelid opened this issue Nov 10, 2021 · 2 comments · Fixed by #1669
Labels
E-medium Difficulty: might require some prior knowledge or code reading

Comments

@camelid
Copy link
Member

camelid commented Nov 10, 2021

https://rustc-dev-guide.rust-lang.org/building/bootstrapping.html#why-does-only-libstd-use-cfgbootstrap

cc https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/rename.20.60cfg.28bootstrap.29.60.20to.20.60cfg.28stageN.29.60
@camelid camelid added the E-medium Difficulty: might require some prior knowledge or code reading label Nov 10, 2021
@camelid
Copy link
Member Author

camelid commented Jan 9, 2022 •
edited
Loading

It also misleadingly says that rustc only uses cfg(bootstrap) when adding internal lints for diagnostic items. That's not true; rustc also uses cfg(bootstrap) when feature gates that are used internally are renamed or removed.

@jyn514
Copy link
Member

jyn514 commented Apr 8, 2023

The docs for cfg(bootstrap) are here: https://rustc-dev-guide.rust-lang.org/building/bootstrapping.html#complications-of-bootstrapping. Maybe it would help to link there from the libstd section?

It also misleadingly says that rustc only uses cfg(bootstrap) when adding internal lints for diagnostic items. That's not true; rustc also uses cfg(bootstrap) when feature gates that are used internally are renamed or removed.

👍 I'll fix this.

@jyn514 jyn514 mentioned this issue Apr 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-medium Difficulty: might require some prior knowledge or code reading
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify cfg(bootstrap) docs jyn514/rustc-dev-guide
2 participants
@jyn514 @camelid