Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest dev version (a642651) hangs forever on link.exe #1553

Closed
frederikhors opened this issue Jan 11, 2025 · 8 comments · Fixed by #1554
Closed

Latest dev version (a642651) hangs forever on link.exe #1553

frederikhors opened this issue Jan 11, 2025 · 8 comments · Fixed by #1554
Labels
C-bug Category: This is a bug. O-windows Operating system: Windows

Comments

@frederikhors
Copy link

Tried today the latest dev version and the cargo-clif build`` is stopping on link.exe` forever!

I'm coming from cargo 1.85.0-nightly (769f622e1 2024-12-14) that works OK.

I'm on Microsoft 14.42.34433.0, Windows 11.

@bjorn3
Copy link
Member

bjorn3 commented Jan 11, 2025

I'm afraid I don't have a clue what could be going on. Maybe if you can bisect it to the exact commit that introduced this issue that would help explain it? If you don't want to build cg_clif locally, you can download the CI artifacts for a specific commit from https://github.com/rust-lang/rustc_codegen_cranelift/actions/workflows/main.yml?query=branch%3Amaster If you click on the CI run for the commit in question, you can scroll down to the bottom to see the release artifacts. Github only keeps them for a relatively limited amount of time, though I expect the artifacts for 2024-12-14 to still exist.

@bjorn3
Copy link
Member

bjorn3 commented Jan 11, 2025

Actually maybe 4cc1c90 is the offending commit? Can you check if it works on the commit before this and breaks with this commit?

@frederikhors
Copy link
Author

frederikhors commented Jan 14, 2025

4cc1c90 has the issue. Plus it's very, very, very slower before arriving to the last crate (when it calls link.exe).

7f98f34 doesn't have the problem. And it works with similar timing to the commit I've been using so far.

@bjorn3 bjorn3 added C-bug Category: This is a bug. O-windows Operating system: Windows labels Jan 14, 2025
@bjorn3
Copy link
Member

bjorn3 commented Jan 14, 2025

Thanks for confirming that 4cc1c90 is the issue. Would you mind testing #1554? This disables -Zfunction-section again, but only on Windows.

@frederikhors
Copy link
Author

I'll try it when it's ready.

@bjorn3
Copy link
Member

bjorn3 commented Jan 14, 2025

It is ready. The last push to the PR was just a cosmetic thing. CI failure on FreeBSD exists on master too. Something broke on the rustc side.

@frederikhors
Copy link
Author

frederikhors commented Jan 14, 2025

I tried msvc bundle from https://github.com/rust-lang/rustc_codegen_cranelift/actions/runs/12772502374.

It works!

@bjorn3
Copy link
Member

bjorn3 commented Jan 20, 2025

Opened rust-lang/rust#135776 to sync the fix to the rust repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. O-windows Operating system: Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants