Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap_comments doesn't reflow text. #2968

Open
alercah opened this issue Aug 26, 2018 · 1 comment
Open

wrap_comments doesn't reflow text. #2968

alercah opened this issue Aug 26, 2018 · 1 comment
Labels
a-comments only-with-option requires a non-default option value to reproduce poor-formatting

Comments

@alercah
Copy link

alercah commented Aug 26, 2018

Another one for wrap_comments:

/// this
/// is
/// an
/// unnecessarily
/// tall
/// comment.
fn foo() {}

The formatter doesn't format these comments

While this may be desirable in some cases, (e.g. TODOs), in light of #627, perhaps a better general solution is to add a markdown formatter and use it inside doc comments, since those are necessarily Markdown, ideally independently of whether or not non-doc comments are formatted.

@nrc nrc added poor-formatting a-comments only-with-option requires a non-default option value to reproduce labels Aug 26, 2018
@ytmimi
Copy link
Contributor

ytmimi commented Jul 20, 2022

Confirming I can reproduce this using rustfmt 1.5.1-nightly (0f93f53e 2022-07-19)

Not sure if this is actually an issue with wrap_comments, but going to link the wrap_comments tracking issue #3347 just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-comments only-with-option requires a non-default option value to reproduce poor-formatting
Projects
None yet
Development

No branches or pull requests

3 participants