`rustup doc` appears to do nothing #1125

Diggsey · 2017-05-17T15:21:48Z

I do see behavior on a headless linux machine where rustup doc appears to do nothing.

nodakai · 2017-06-25T15:20:37Z

$ docker run -it --name rustup-doc --security-opt seccomp:unconfined debian:jessie
# apt-get update
# apt-get -y install curl less strace
# curl https://sh.rustup.rs -sSf | sh
# PATH=$PATH:$HOME/.cargo/bin
# strace -f -s100 rustup doc |& less

In this case rustup was satisfied with just successfully launching sensible-browser when it actually complained as below and returned 1:

Couldn't find a suitable web browser!
Set the BROWSER environment variable to your desired browser.

https://github.com/rust-lang-nursery/rustup.rs/blob/master/src/rustup-utils/src/raw.rs#L364

ghost · 2017-07-16T09:56:20Z

$ time rustup doc

real	0m0.308s
user	0m0.290s
sys	0m0.017s

Exit code is 0.

According to strace, it executed
/usr/bin/xdg-open /home/xftroxgpx/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/doc/rust/html/index.html
The above(xdg-open command) shows elinks (a browser running in console) when I run it myself from xfce4-terminal and it seems to work ok. But with rustup it shows nothing.

Maybe rustup doc could always say the command it executes, so that if it fails, user can copy/paste and manually execute it?

EDIT: using this patch for my own needs.

Natim · 2017-11-08T09:15:10Z

In my case it tried to open gvfs-open ~/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/share/doc/rust/html/index.html however the html folder doesn't exists here.

Natim · 2017-11-08T09:15:31Z

~/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/share/doc$ tree
.
├── cargo
│   ├── LICENSE-APACHE
│   ├── LICENSE-MIT
│   ├── LICENSE-THIRD-PARTY
│   └── README.md
└── rust
    ├── COPYRIGHT
    ├── LICENSE-APACHE
    ├── LICENSE-MIT
    └── README.md

I used rustup component add rust-docs to install them and it fixed it!

nbro · 2018-01-18T16:36:39Z

I was also having this problem on Mac OS X, version 10.13.2. I executed

rustup component add rust-docs

as suggested by @Natim, and then I executed again

rustup doc

and a browser tab automatically opened, in my case, on Chrome, with the offline documentation.

pickfire · 2018-08-08T16:45:25Z

@Diggsey Maybe you are looking for rustup man?

britishben · 2019-01-10T12:32:14Z

In my case, it was because I don't have xdg-open installed, and /bin/open is symlinked to /bin/openvt in Ubuntu (referenced here). Maybe require xdg-open as a dependency?

Passing back an error message would be much more helpful than the current behaviour of failing silently.

ghost · 2019-01-10T15:22:07Z

tl;dr: @britishben set BROWSER env. var. to the browser executable you want rustup doc to open the docs with. (doesn't have to be full path, anything in PATH seems to work too)

For me, xdg-open runs elinks(a browser that runs in the text terminal eg. in xfce4-terminal) but when rustup doc tries to execute it, it does so with stdin/stdout/stderr redirected to /dev/null but because stdout is redirected to /dev/null, elinks(in my case) just exits. Perceived result: rustup doc does nothing.

So this does nothing and returns exit code 0:

$ xdg-open "/home/xftroxgpx/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/doc/rust/html/index.html" </dev/null 2>&1 >/dev/null ; echo "exit code:$?"
exit code:0

But this works and runs elinks just fine(and then I exit with q key):

$ xdg-open "/home/xftroxgpx/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/doc/rust/html/index.html" </dev/null 2>&1 ; echo "exit code:$?"
exit code:0

Workaround: set the BROWSER env. var to the browser executable you want rustup doc to run to open the docs with:

;// before:
$ rustup doc
!! executing: xdg-open "/home/xftroxgpx/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/doc/rust/html/index.html"

;// after
$ export BROWSER=chro2
$ rustup doc
!! executing: chro2 "/home/xftroxgpx/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/doc/rust/html/index.html"

If the BROWSER env. var. points to an invalid/notfound command then it falls back to the list in let commands:

https://github.com/rust-lang/rustup.rs/blob/1dd60c40f7eb8a302ab54cded0e5a2b0d530adeb/src/rustup-utils/src/raw.rs#L371-L385

I'm personally still using a patch to mitigate this instead. (even though ~/.cargo/bin/rustup gets overwritten upon every successful rustup update of the nightly toolchain, or at least it used to(I haven't tried recently); so I'd have to recompile&reinstall my modified rustup again :D)

istankovic · 2019-07-04T21:41:53Z

@xftroxgpx I had the exact same problem and it was quite interesting to see what went wrong. The question is, why does xdg-open try to invoke elinks, even though xdg-settings get default-web-browser returns firefox.desktop?

xdg-open invokes exo-open, as it should, which then proceeds to execute gio-launch-desktop. Now, gio-launch-desktop will read /usr/share/applications/mimeinfo.cache and presumably return the first registered application for the MIME type. In particular, my entry looks like this:

text/html=elinks.desktop;firefox.desktop;

So it seems that as soon as you install another browser, there is a chance that the entry is updated in an unintended way. The cache file is updated by update-desktop-database when a package is installed (I'm using Archlinux). My first thought was that update-desktop-database is adding the entries based on sorted names so that's why elinks.desktop comes before firefox.desktop. However, that seems not to be the case, as evidenced by the updated entry after I installed chromium:

text/html=elinks.desktop;firefox.desktop;chromium.desktop;

I'd love to know what really happened here.
Of course, removing chromium will also result in removing the corresponding .desktop entry from the cache file, which hints at one way to work around this rustup issue.

But since we all love elinks and have it installed for a reason, we can just put this:

[Default Applications]
text/html=firefox.desktop;elinks.desktop

into /etc/xdg/mimeapps.list. For user-override, use ~/.config/mimeapps.list instead.

kinnison · 2019-07-05T05:43:30Z

The mime handlers ought to include information on how to deal with terminal vs. not terminal. I wonder why they don't.

japrogramer · 2019-10-19T03:47:59Z

my rustup doc --std does nothing

errors.txt

and my miapps
[Added Associations]
text/html=firefox.desktop;elinks.desktop;
application/pdf=firefox.desktop;
x-scheme-handler/http=firefox.desktop;
x-scheme-handler/https=firefox.desktop;
x-scheme-handler/ftp=firefox.desktop;
x-scheme-handler/chrome=firefox.desktop;
text/html=firefox.desktop;
application/x-extension-htm=firefox.desktop;
application/x-extension-html=firefox.desktop;
application/x-extension-shtml=firefox.desktop;
application/xhtml+xml=firefox.desktop;
application/x-extension-xhtml=firefox.desktop;
application/x-extension-xht=firefox.desktop;

kinnison · 2019-10-19T09:55:06Z

Do you have the rust-docs component installed? (Silly question, but it's possible you might not)

Otherwise this might be another opener bug in which case @Seeker14491 might have some input/questions.

japrogramer · 2019-10-19T23:12:33Z

yes, i have it installed.

Seeker14491 · 2019-10-20T04:59:56Z

I believe I've figured out what can cause the browser not to open: xdg-open is being ran with a null stdout. Using the lynx browser, links don't open for me. Changing stdout to the default of inherit causes the browser to open properly.

@japrogramer could you share what distro, desktop environment, and web browser combination is not working for you so I can try to reproduce the issue?

japrogramer · 2019-10-20T05:50:57Z

@Seeker14491 I am using arch Linux, sway wm and Firefox.

Seeker14491 · 2019-10-22T02:50:49Z

I've opened Seeker14491/opener#4 to track this bug.

jdl · 2019-11-17T18:56:33Z

But since we all love elinks and have it installed for a reason, we can just put this:
[Default Applications]
text/html=firefox.desktop;elinks.desktop
into /etc/xdg/mimeapps.list. For user-override, use ~/.config/mimeapps.list instead.

Thank you. I was going crazy trying to figure out why on only one of my machines when I ran rustup doc it would open Postman.

Sure enough:

$ more ~/.config/mimeapps.list 

[Default Applications]
text/html=Postman.desktop
x-scheme-handler/postman=Postman.desktop

gdnathan · 2021-06-24T00:37:59Z

up,
/usr/bin/xdg-open /home/erudyx/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/doc/rust/html/index.html works just fine, but rustup doc or rustup doc --book does absolutely nothing

Seeker14491 · 2021-06-24T01:20:41Z

@Erudyx could you respond to Seeker14491/opener#4 (comment)? Also, I'd like to know what's your distro and browser so I can try to reproduce this.

garasubo · 2021-10-15T05:50:57Z

According to this comment, this issue has been resolved since opener version is now 0.5?

kinnison · 2022-07-13T20:19:56Z

1.25 is now out

Diggsey added bug E-easy help wanted labels May 17, 2017

Diggsey mentioned this issue May 17, 2017

Add better usage when running rustup doc #1046

Closed

LPGhatguy mentioned this issue May 2, 2019

Migrate browser opening logic to match Cargo #1830

Merged

Seeker14491 mentioned this issue Oct 22, 2019

Browser not opening on Linux Seeker14491/opener#4

Closed

rusty-snake mentioned this issue Aug 9, 2020

firefox: cannot open docs in ~/.rustup netblue30/firejail#3576

Open

4 tasks

Zieng mentioned this issue Mar 12, 2021

rustup doc not working on m1 macbook #2692

Closed

kinnison removed the bug label Nov 8, 2021

kinnison added fixed-next-release This issue will be fixed in the next release of rustup. and removed help wanted E-easy labels Nov 8, 2021

kinnison closed this as completed Jul 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`rustup doc` appears to do nothing #1125

`rustup doc` appears to do nothing #1125

Diggsey commented May 17, 2017

nodakai commented Jun 25, 2017

ghost commented Jul 16, 2017 •

edited by ghost

Loading

Natim commented Nov 8, 2017

Natim commented Nov 8, 2017 •

edited

Loading

nbro commented Jan 18, 2018 •

edited

Loading

pickfire commented Aug 8, 2018

britishben commented Jan 10, 2019 •

edited

Loading

ghost commented Jan 10, 2019

istankovic commented Jul 4, 2019

kinnison commented Jul 5, 2019

japrogramer commented Oct 19, 2019 •

edited

Loading

kinnison commented Oct 19, 2019

japrogramer commented Oct 19, 2019

Seeker14491 commented Oct 20, 2019

japrogramer commented Oct 20, 2019

Seeker14491 commented Oct 22, 2019

jdl commented Nov 17, 2019

gdnathan commented Jun 24, 2021

Seeker14491 commented Jun 24, 2021

garasubo commented Oct 15, 2021

kinnison commented Jul 13, 2022

rustup doc appears to do nothing #1125

rustup doc appears to do nothing #1125

Comments

Diggsey commented May 17, 2017

nodakai commented Jun 25, 2017

ghost commented Jul 16, 2017 • edited by ghost Loading

Natim commented Nov 8, 2017

Natim commented Nov 8, 2017 • edited Loading

nbro commented Jan 18, 2018 • edited Loading

pickfire commented Aug 8, 2018

britishben commented Jan 10, 2019 • edited Loading

ghost commented Jan 10, 2019

istankovic commented Jul 4, 2019

kinnison commented Jul 5, 2019

japrogramer commented Oct 19, 2019 • edited Loading

kinnison commented Oct 19, 2019

japrogramer commented Oct 19, 2019

Seeker14491 commented Oct 20, 2019

japrogramer commented Oct 20, 2019

Seeker14491 commented Oct 22, 2019

jdl commented Nov 17, 2019

gdnathan commented Jun 24, 2021

Seeker14491 commented Jun 24, 2021

garasubo commented Oct 15, 2021

kinnison commented Jul 13, 2022

`rustup doc` appears to do nothing #1125

`rustup doc` appears to do nothing #1125

ghost commented Jul 16, 2017 •

edited by ghost

Loading

Natim commented Nov 8, 2017 •

edited

Loading

nbro commented Jan 18, 2018 •

edited

Loading

britishben commented Jan 10, 2019 •

edited

Loading

japrogramer commented Oct 19, 2019 •

edited

Loading