Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check formatting on CI #1393

Closed
cyplo opened this issue Apr 14, 2018 · 2 comments
Closed

Check formatting on CI #1393

cyplo opened this issue Apr 14, 2018 · 2 comments

Comments

@cyplo
Copy link
Contributor

cyplo commented Apr 14, 2018

While the code now conforms to the default rules of rustfmt it can be easy for it to diverge, as there is no feedback if someone introduces a change that is not formatted properly.
A CI build job that fails when formatting is off could be useful.

See discussion in #1390 for more background - in short it is not easy to specify a version of rustfmt that we can rely on.

@tesuji
Copy link
Contributor

tesuji commented May 8, 2019

@kinnison This should be closed .

@kinnison
Copy link
Contributor

kinnison commented May 8, 2019

Indeed it should, well spotted.

We have been checking formatting as part of CI for several months now.

@kinnison kinnison closed this as completed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants