Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show targets in toolchain names by default in the UI #461

Closed
brson opened this issue May 14, 2016 · 3 comments
Closed

Don't show targets in toolchain names by default in the UI #461

brson opened this issue May 14, 2016 · 3 comments

Comments

@brson
Copy link
Contributor

brson commented May 14, 2016

I had an issue about this before but lost it.

I've seen people confused that they should be installing stable-$target to do cross-compiling. For the most part the host architecture doesn't matter. If you care about the host architecture it will be set as in #421 and reported in rustup show. We don't need to say it all the time.

Not showing target names in toolchain names makes it more obvious that you generally use target triples to specify targets, not toolchains.

So everywhere the UI shows e.g. stable-x86_64-unknown-linux-gnu it will instead say stable. Unless the toolchain's target is not the same as the default host per #421, or the user actually requested a different target explicitly.

@nrc This is related to some of the question you had today. The distinction between the host and target platform is a fairly confusing topic.

cc @alexcrichton @Diggsey

@brson
Copy link
Contributor Author

brson commented May 14, 2016

On the other hand, we could also unify the idea of toolchains and targets and make stable-$any-target just work.

@Diggsey
Copy link
Contributor

Diggsey commented May 14, 2016

I agree with hiding the host triple portion of the toolchain name when it matches the configured host.

I don't think we should unify the idea of toolchains and targets, because 1) it does have some uses, 2) there are still some subtle differences between a rustc with host X, target Y and a rustc with host Y, target Y, 3) it's potentially even more confusing, if only because it's much further from what's actually happening, and 4) it would take quite a while to get rustup relatively stable again after such a massive change.

I think the solution is to de-emphasise the use of toolchains, introducing it purely as a means to switch between release channels and versions, and not introduce toolchain-triple switching at that point. In combination with hiding the triple this should simplify basic usage.

It may also be worth moving the override and default subcommands into the toolchain subcommand (with undocumented aliases for back-compat) in case we want to add target overrides too at some later time, which we can do at our leisure, without compromising the rest of the functionality. (Also people who don't want rustup to start messing with their compile flags can just avoid using that functionality)

@Diggsey
Copy link
Contributor

Diggsey commented May 4, 2017

Found it: #351

@Diggsey Diggsey closed this as completed May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants