Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change PR to "waiting on author" after "changes requested" review #1373

Closed
nikomatsakis opened this issue Jun 2, 2021 · 2 comments · Fixed by #1379
Closed

change PR to "waiting on author" after "changes requested" review #1373

nikomatsakis opened this issue Jun 2, 2021 · 2 comments · Fixed by #1379

Comments

@nikomatsakis
Copy link
Contributor

It would be useful if rustbot changed the status of a PR to S-waiting-on-author after observing a "changes requested" review from the assigned reviewer.

Branched out from #1339
@nikomatsakis nikomatsakis mentioned this issue Jun 2, 2021
Closed
@mibac138 mibac138 mentioned this issue Jun 6, 2021
Merged
@oli-obk
Copy link
Contributor

oli-obk commented Oct 11, 2021

I don't think this is working anymore, or at least not for Draft PRs?

See rust-lang/rust#89745 for an example

@tgross35
Copy link
Contributor

Seems like this still doesn't work so I opened #1857

@ehuss ehuss mentioned this issue Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add review_submitted handler which changes labels after a review mibac138/triagebot
3 participants
@nikomatsakis @oli-obk @tgross35