-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl PartialEq, Eq for rngs #979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
reviewed
May 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct, but we overlooked a bug in 😬get_word_pos
in your port of our ChaCha code
Edit: I was wrong (see #980). Rebase please.
Closed
Implements rust-random#974. As in rust-random#975, but defining equality such that the user is not exposed to the fact that one logical state may have different representations in an implementation-specific way.
@dhardy, Squashed and rebased. |
dhardy
approved these changes
May 29, 2020
vks
added a commit
to vks/rand
that referenced
this pull request
Aug 24, 2020
This reverts a change from rust-random#979 that introduced a massive performance regression by disabling SIMD for `rand_chacha`. Likely, the behavior of `ppv-lite86` should rather be fixed. This change serves as a workaround until a fixed version is available. Fixes rust-random#1017.
Merged
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #964. As in #975, but defining equality such that the user is
not exposed to the fact that one logical state may have different
representations in an implementation-specific way.