Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config)!: multiple paths in config profile as array #1124

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Apr 18, 2024

-- BREAKING CHANG --

Using multiple paths for a sources in the config file caused many problems as the syntax was unclear and problems existed in edge cases.

This PR changes the definition of sources in config profile files:

  • a single path path can be specified as before, i.e. using source = "/my/path".
  • multiple paths must now be given in an array:
source = ["/my/path1", "/my/path2"]

Note that

source = "/my/path1 /my/path2"

is now interpreted a a single path using the dir-tree "my","path1 " (with space), "my", "path2".

closes #1122
closes #1094

Copy link
Member Author

@aawsome aawsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aawsome aawsome merged commit 9980a36 into main Apr 18, 2024
25 checks passed
@aawsome aawsome deleted the multiple-sources branch April 18, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant