Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Closure::once in gloo-timers #39

Closed
fitzgen opened this issue Mar 22, 2019 · 1 comment · Fixed by #48
Closed

Use Closure::once in gloo-timers #39

fitzgen opened this issue Mar 22, 2019 · 1 comment · Fixed by #48
Labels
assigned This issue has someone working on it bug Something isn't working good first issue Good for newcomers

Comments

@fitzgen
Copy link
Member

fitzgen commented Mar 22, 2019

We can fix this TODO:

https://github.com/fitzgen/gloo/blob/ea02bfaaf5413b5e50cc6f74a882d97a9e164ee5/crates/timers/src/lib.rs#L113-L119

Since the linked PR merged and there's been a wasm-bindgen release with the new API: https://docs.rs/wasm-bindgen/0.2.40/wasm_bindgen/closure/struct.Closure.html#method.once
@fitzgen fitzgen added bug Something isn't working good first issue Good for newcomers labels Mar 22, 2019
@OddCoincidence
Copy link
Contributor

OddCoincidence commented Mar 22, 2019 •
edited
Loading

I can do this (I'll wait until #38 is merged though to avoid conflicts)

@fitzgen fitzgen added the assigned This issue has someone working on it label Mar 22, 2019
@OddCoincidence OddCoincidence mentioned this issue Mar 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned This issue has someone working on it bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

timers: use Closure::once for timeouts
2 participants
@fitzgen @OddCoincidence