Can't get window.location

[dakom]

Assuming a function to get the window as a Result, like this:

fn get_window () -> Result<web_sys::Window, JsValue> {
    web_sys::window().ok_or(JsValue::from_str("couldn't get window"))
}

I can successfully get some other properties of the window, like inner_width:

fn get_inner_width() -> Result<f64, JsValue> {
    let size = get_window()?.inner_width()?.as_f64().ok_or(JsValue::from_str("uhoh"))?;
    Ok(size)
}

But trying to get the location fails:

let location_origin = get_window()?.location().origin()?; 

In case it matters, the use case is something like this:

pub fn same_origin(url:&str) -> Result<bool, JsValue> {
    if url.starts_with("http://") || url.starts_with("https://") {
        let location_origin = get_window()?.location().origin()?; 
        let url = Url::new(url)?;
        Ok(url.origin() == location_origin)
    } else {
        Ok(true)
    }
}

Not sure if this is related to #780 or #659

[chinedufn]

Try this https://rustwasm.github.io/wasm-bindgen/api/web_sys/struct.Document.html#method.location

(Sorry on mobile typing is a pain)

[alexcrichton]

I think this may have been a bug I've forgotten to publish actually, I just published new versions of all crates though! @dakom want to update and see if it's fixed now?

[alexcrichton]

Ah I can't get that to build unfortunately, do you have some steps though that could help me out?

[alexcrichton]

Oh if it's just a question of compiling (sorry, I thought it was runtime failing), then as mentioned in the documentation you'll need to enable a few features of the web-sys crate

[alexcrichton]

Either way's fine, I can do so here!