Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth permission was asked during onboarding #1355

Open
markoaamunkajo opened this issue Mar 7, 2023 · 10 comments
Open

Bluetooth permission was asked during onboarding #1355

markoaamunkajo opened this issue Mar 7, 2023 · 10 comments
Labels
bug Something isn't working
Milestone

Comments

@markoaamunkajo
Copy link
Collaborator

Description:

User made fresh installation of app, then went through onboarding slides

Actual: user was shown Bluetooth permission popup when he was on signin page.
Expected: should ask only when it's necessary

  • User is adding new sensor first time on Add New Sensors
  • User signed into cloud and is using mixed mode
@markoaamunkajo markoaamunkajo added the bug Something isn't working label Mar 7, 2023
@markoaamunkajo markoaamunkajo added this to the 2.1.0 milestone Mar 7, 2023
@priyonto priyonto added 16h 8h and removed 16h labels Mar 15, 2023
@markoaamunkajo markoaamunkajo modified the milestones: 2.0.2, 2.1.0 Mar 27, 2023
@markoaamunkajo markoaamunkajo modified the milestones: 2.1.0, 2.3 Apr 10, 2023
@markoaamunkajo
Copy link
Collaborator Author

Not high priority for now, moved to 2.3

@priyonto
Copy link
Collaborator

Found it. Its how BTKit is implemented and used on the app. And, I would prefer not to do anything about it since its going to affect the whole BT scanning mechanism across the application. And, the outcome is not also not something significant from all those changes even if we do it.

@priyonto priyonto assigned markoaamunkajo and unassigned priyonto Jun 26, 2023
@markoaamunkajo
Copy link
Collaborator Author

Closing this, will be handled in BTKit repository with card ruuvi/BTKit#1

@markoaamunkajo markoaamunkajo removed their assignment Jun 27, 2023
@markoaamunkajo markoaamunkajo reopened this Feb 2, 2024
@markoaamunkajo
Copy link
Collaborator Author

Reopened, this issue was not handled due to not being on board.

@rinat-enikeev
Copy link
Contributor

fixed in #1925 and ruuvi/BTKit#13

@DG12
Copy link
Contributor

DG12 commented Feb 5, 2024

The request for permission to bluetooth, even though the instance of station has been running for a while(?) and Bluetooth access is already granted, occurs very rarely. Is there a way to check permission and if (seemly not) check a second time?

For me, VERY minor issue but I thought I should let you know.

@markoaamunkajo
Copy link
Collaborator Author

@rinat-enikeev 2.6.0 (2402061941)

If I open app and leave it untouched on first onboarding for a few minutes I will see permission popup.

Image

@markoaamunkajo markoaamunkajo added bug Something isn't working and removed investigation labels Feb 7, 2024
@markoaamunkajo
Copy link
Collaborator Author

2.6.1 (2402111104) Firebase build. Still shows if user keeps the code screen open for a while.

Image

@markoaamunkajo
Copy link
Collaborator Author

@rinat-enikeev Was the BTKit side fix already done? Can this be then fixed on the app side already?

@markoaamunkajo markoaamunkajo modified the milestones: 2.7, 2.8 Feb 23, 2024
@DG12
Copy link
Contributor

DG12 commented Feb 23, 2024

It seems that for on boarding station must ask permission once.
It should ask again ONLY if no longer has permission.

@markoaamunkajo markoaamunkajo modified the milestones: 2.8, 2.12 Aug 15, 2024
@markoaamunkajo markoaamunkajo modified the milestones: 2.12, 2.13 Sep 5, 2024
@markoaamunkajo markoaamunkajo modified the milestones: 2.13, 2.14 Nov 20, 2024
@markoaamunkajo markoaamunkajo modified the milestones: 2.14, 2.15 Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants