Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample battery voltage at interval #87

Closed
ojousima opened this issue Jul 9, 2020 · 2 comments · Fixed by #92
Closed

Sample battery voltage at interval #87

ojousima opened this issue Jul 9, 2020 · 2 comments · Fixed by #92
Assignees
@opsationby
Labels
Pending Work is complete, waits for merge to master
Milestone
3.29.0

Comments

@ojousima
Copy link
Member

ojousima commented Jul 9, 2020

Current battery voltage sampling gets triggered on every radio transmission, which is unnecessarily often.
A logic to update the voltage only once per minute, with interval configurable in application_mode_default.h should be added.
Related to #86

/** @brief Resample battery voltage at this interval */
#ifndef APP_BATTERY_SAMPLE_MS
#   define APP_BATTERY__SAMPLEL_MS (60U*1000U)
#endif
@ojousima ojousima assigned ojousima and opsationby and unassigned ojousima Jul 9, 2020
@ojousima ojousima added this to the 3.29.0 milestone Jul 10, 2020
@opsationby opsationby linked a pull request Jul 15, 2020 that will close this issue
Issue 87 #92
Merged
@ojousima
Copy link
Member Author

Fixed in #92, marking as pending. Thanks

@ojousima ojousima added the Pending Work is complete, waits for merge to master label Jul 15, 2020
@ojousima
Copy link
Member Author

ojousima commented Sep 9, 2020

Done in 7a9da7c

@ojousima ojousima closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@opsationby opsationby

Labels
Pending Work is complete, waits for merge to master
Projects
None yet
Milestone
3.29.0
Development

Successfully merging a pull request may close this issue.

Issue 87 opsationby/ruuvi.firmware.c
2 participants
@ojousima @opsationby