Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting rules to prevent false positives when merging pull requests #23

Closed
jhoek opened this issue Nov 26, 2021 · 0 comments
Closed
Labels
enhancement New feature or request shipped Issue is available in the public release.

Comments

@jhoek
Copy link
Contributor

jhoek commented Nov 26, 2021

When examining the differences introduced by a pull request, it's nice not to be distracted by false positives due to different code formatting styles (e.g. spaces around operators, placement of curly brackets, use of new line characters etc.) - relevant changes could easily be missed in a haystack of "noise".

Before working on any other pull requests, I would like to suggest the introduction of a workspace settings file containing the project's formatting rules. By putting this into the repo, all developers use the same rules (as workspace settings override user settings).

Note that this assumes that most people these days use VS Code to edit their PowerShell files.

@rvanbekkum rvanbekkum added enhancement New feature or request ships-in-future-update Resolution will be available in the next release. shipped Issue is available in the public release. and removed ships-in-future-update Resolution will be available in the next release. labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shipped Issue is available in the public release.
Projects
None yet
Development

No branches or pull requests

2 participants