Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case of fatal exceptions, it might be better to stop the execution of the cmdlet #5

Closed
jhoek opened this issue Mar 30, 2021 · 1 comment
Labels
enhancement New feature or request shipped Issue is available in the public release.

Comments

@jhoek
Copy link
Contributor

jhoek commented Mar 30, 2021

I ran Sync-XliffTranslations with a path that the cmdlet considered invalid (see also my other issue). As a result, the file could not be loaded and I got this error message:

Exception calling "Load" with "1" argument(s): "Could not find a part of the path 'C:\Users\MyUserName\Translations\MyCompanyName Extension.g.xlf'."

However, execution continued as normal, leading to a wall of red text. Subsequent attemps to load other files (i.c. the target file) failed for the same reason.

I would argue that file load failures should be treated as fatal, and execution should stop immediately.

@rvanbekkum rvanbekkum added the investigate Needs some investigation label Apr 18, 2021
@rvanbekkum rvanbekkum added enhancement New feature or request ships-in-future-update Resolution will be available in the next release. shipped Issue is available in the public release. and removed investigate Needs some investigation ships-in-future-update Resolution will be available in the next release. labels Sep 29, 2021
@rvanbekkum
Copy link
Owner

Changes for this have been shipped in the new release, version 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shipped Issue is available in the public release.
Projects
None yet
Development

No branches or pull requests

2 participants