Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot escape "Parse From Developer Note Separator" #115

Open
yurim108 opened this issue Mar 2, 2023 · 2 comments
Open

Cannot escape "Parse From Developer Note Separator" #115

yurim108 opened this issue Mar 2, 2023 · 2 comments
Labels
effort: medium Initial effort estimate: Medium enhancement New feature or request priority: medium Priority estimate: Medium

Comments

@yurim108
Copy link

yurim108 commented Mar 2, 2023

Pipeline (|) is setup as a default separator.
How to deal with the situation when the pipeline must be included into translation (in the middle of a running project)?

Example:
ConfigFileFilterLbl: Label 'JSON files (.json)|.json|All files (.)|.', Comment = 'de-DE=JSON Dateien (.json)|.json|Alle Dateien (.)|.';

Changing default separator would mean that we need to check all other existing translations, whether they include the new separator.

Suggested solution: when the separator occures twice (||) then treat it as a single pipeline without separator functionality.
In this case one would have to escape the pipeline in the translated text like this:

ConfigFileFilterLbl: Label 'JSON files (.json)|.json|All files (.)|.', Comment = 'de-DE=JSON Dateien (.json)||.json||Alle Dateien (.)||.';

Another solution would be to define a line specific separator like this:
ConfigFileFilterLbl: Label 'JSON files (.json)|.json|All files (.)|.', Comment = 'Separator=##de-DE=JSON Dateien (.json)|.json|Alle Dateien (.)|.#fr-FR=.......';

@rvanbekkum
Copy link
Owner

Dear @yurim108,

Thank you for your issue. Sorry about the later reply.

I think your second suggestion might work best. What do you think yourself?
I will have a look at it.

@rvanbekkum rvanbekkum added effort: medium Initial effort estimate: Medium priority: medium Priority estimate: Medium enhancement New feature or request labels Jun 19, 2023
@yurim108
Copy link
Author

Dear Rob,

I have solved it for now by using double pipeline as a separator.
I would also go with the 2nd option.

It would be nice to get a warning, if the source text contains separator (in case when the separator is redefined in the line, the new check should use the redefined separator).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Initial effort estimate: Medium enhancement New feature or request priority: medium Priority estimate: Medium
Projects
None yet
Development

No branches or pull requests

2 participants