Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with Parse From Developer Node #43

Closed
GregoryAA opened this issue Apr 22, 2020 · 3 comments
Closed

issue with Parse From Developer Node #43

GregoryAA opened this issue Apr 22, 2020 · 3 comments
Labels
enhancement New feature or request shipped Issue is available in the public release.

Comments

@GregoryAA
Copy link

Hello Rob,

Set in extension setup Parse From Developer Node =true

  1. Add new label
    image
  2. Build app with Ctrl+Shift+B
  3. Synchronize Translation Unit
    image
  4. Add developer comment and build app
    image
  5. Synchronize Translation Unit again
  6. No changes in translation
    image
  7. Delete target and re-sync
  8. All works as expected
    image

The same situation if developer decide to change translation in comment
image
rebuild app and re-sync
image

Also could you provide the snippet for create developer comments like in AL Language Tools extension
image

@rvanbekkum
Copy link
Owner

Dear @GregoryAA,
Thank you for reporting this issue.

To summarize, we have the following three points to address:

  1. "Parse from Developer Note" should copy the translation from the Developer note also in case that a trans-unit already exists with target state="needs-translation". This sounds logical, I'll look into it.
  2. "Parse from Developer Note" is currently not copying a new translation from the Developer note if a translation already exists. This was actually intentional, but I can also see why you'd want to have the translation always updated from the Developer note (if it exists). Perhaps I could add an option, like parseFromDeveloperNoteOverride that will toggle this behaviour. What do you think? If you have other ideas, please share! :)
  3. This would be an AL-specific feature, but I think I'd could add this specific feature. Can you share some ideas of how you'd like this snippet to work?

@rvanbekkum rvanbekkum added enhancement New feature or request input-needed Extra attention is needed labels Apr 26, 2020
@GregoryAA
Copy link
Author

Hello Rob,

  1. Maybe you could add new action "Update Translation from Dev. node" in the context menu under Synchronize Translation Unit? It seems to me that such an opportunity should always be at hand with the developer.
    image
  • user enters text tcommetwithtranslation
  • selects a snippet from the context menu
    image

-VS code inserts text: comment = 'LanguageCode=YourLanguageText'
image

  • after inserting the snippet, the LanguageCode area becomes active, where the user enters, for example nl-NL and then press TAB, the area YourLanguageText is activated and user enters the translation.

also maybe you can add another snippets for label, tooltip, caption.

tLabelwithComment
LabelName: Label 'EnglishText', comment = 'LanguageCode=YourLanguageText';

tTolTipwithComment
ToolTip = 'EnglishText', comment = 'LanguageCode=YourLanguageText';

tCaptionwithComment
Caption = 'EnglishText', comment = 'LanguageCode=YourLanguageText';

Often, programmers work with one language for translation. It would be nice to save the code of this language in the settings. Then using these snippets we could only enter the translation and the language code would be inserted by default

like this:
comment = 'nl-NL=YourLanguageText'

@rvanbekkum rvanbekkum removed the input-needed Extra attention is needed label May 3, 2020
@rvanbekkum rvanbekkum added the in-progress One of the contributors is working on this. label May 31, 2020
@rvanbekkum rvanbekkum removed the in-progress One of the contributors is working on this. label May 31, 2020
@rvanbekkum
Copy link
Owner

The changes are shipped in version 0.3.8.
Please see the CHANGELOG and the README for the details.

@rvanbekkum rvanbekkum added the shipped Issue is available in the public release. label May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shipped Issue is available in the public release.
Projects
None yet
Development

No branches or pull requests

2 participants