-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releases not being pulled by Ansible Galaxy #236
Comments
It could be related to tests not building on Travis CI. |
I looked a bit into this, just sharing initial bits at this point. The Travis setup has been removed in #235. It used to include this: Lines 54 to 55 in 0fcf5f3
I have no idea if it worked or not, but it looks like an interesting suppression, which could be a cause. Also I came across this interesting post which mentions that also. I believe re-instating a post-release (or post something) POST over there will likely help. I will see if I can make some time to re-instate that this week (but please anyone feel free to jump at it whenever you want if it's doable on your side). |
There are plenty of gha which allows to send web hook notifications. Thing is that Ansible Galaxy seems to only support Travis at the moment: ansible/galaxy#1379 Maybe we should just mimic travis payload, as someone suggested? @sfgeorge do you wanna have a look at this or shall we wait for @thbar? |
Looks like @sfgeorge already had a look into this ansible/galaxy#46 and gave up? Can you say something about it @sfgeorge ? |
Some suggestions here too ansible/galaxy#2070 |
@pkuczynski I didn't start any actual legwork on it, but my comment on ansible/galaxy#46 suggests that perhaps someone write a reusable GitHub Action that uses GitHub Actions many available context variables and transforms them to make a POST to Ansible Galaxy mimic'ing a POST from Travis-CI. Pro: Would avoid having to touch a line of code of Galaxy. |
So it looks there are couple of GHA which allows to achieve the same result: https://github.com/marketplace?type=actions&query=galaxy+ @sfgeorge would you like to tackle that as you were the original author of CI change? |
@pkuczynski short answer – Yeah, I can definitely take a stab, will do 👍 Longer answer – Those solutions use |
Awesome! Thanks! |
@sfgeorge any chance you can give it a shot soon? |
For anyone wondering how to install 2.2.0 in the meantime: As a workaround you can use |
@pkuczynski Apologies, it may be a little while before I can get to this due to other commitments. |
Still an issue:
ok, this works:
then run your playbook as usual:
|
@sfgeorge Have you been able to give a look at the publishing issue? |
Unfortunately I haven't had time to do this. But I want to share my understanding of a few options we have for solving this problem if someone is able to take a stab. Option 1 – ansible-galaxy import (probably easiest) By adding a ansible-galaxy import command to the CI/CD process, we can trigger galaxy importing the latest release. Here's an example (thank you @geerlingguy). Option 2 – Migrate to a Collection We could migrate this standalone galaxy role to a role in a Collection. This would the Galaxy /v2 API as opposed to /v1. However, /v1 is by no means deprecated. There is divided opinion on whether migrating to /v2 provides any particular benefit; some folks feel like the release of /v2 was rushed and problematic. Option 3 – Support build notifications from GitHub Actions Sadly, Ansible Galaxy only supports build status updates from the proprietary Travis CI JSON payload schema. To my knowledge, this might be the only Option that includes getting Galaxy to accurately show a projects builds as passing/failing. We could write a reusable GitHub Action that takes facts from a GitHub Action Job, transforms them into the proprietary format, and pushes the JSON payload to Galaxy. Option 3 has the most features, and Option 1 is by far the simplest to implement. |
I've noticed that the last version published in Ansible Galaxy is 2.1.2.
However, according to the Contributing guidelines page, a new release on GitHub and adding a tag to the master branch is all that's required for it to work.
Looks like something else is missing, because new version 2.2.0 is tagged and it's not on Ansible Galaxy.
The text was updated successfully, but these errors were encountered: