Setup Prettier #162
Merged
Setup Prettier #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelhan
requested changes
Nov 19, 2020
package.json
Outdated
| @@ -19,7 +19,8 @@ | |||
| "start": "ember serve", | |||
| "test": "ember test", | |||
| "test:all": "ember try:each", | |||
| "test:node": "mocha node-tests/**/*-test.js" | |||
| "test:node": "mocha node-tests/**/*-test.js", | |||
| "format": "prettier --write \"./**/*.{md,json,js,yml}\"" | |||
There was a problem hiding this comment.
I would prefer to setup Prettier as ESLint plugin as described in the RFC: https://emberjs.github.io/rfcs/0628-prettier.html#detailed-design My main motivation is that we don't need to change much when this RFC is implemented in Ember CLI.
|
I'll implement all the changes |
implemented prettier with rfc in mind
This was referenced Nov 23, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #157
-added .pretterrc.json
-added prettier script in package.json
-the script was ran on the repo
Please let me know if I need to make changes