Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work when rsync is not installed #55

Closed
calclavia opened this issue Jun 16, 2022 · 6 comments
Closed

Does not work when rsync is not installed #55

calclavia opened this issue Jun 16, 2022 · 6 comments

Comments

@calclavia
Copy link

On certain docker images (node:16, commonly used in CIs) without rsync command installed, this package does not work. Is there a way to fall back to a NodeJS implementation that does not rely on rsync when this occurs?

node:events:505
      throw er; // Unhandled 'error' event
      ^

Error: spawn rsync ENOENT
    at Process.ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:478:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
Emitted 'error' event on ChildProcess instance at:
    at Process.ChildProcess._handle.onexit (node:internal/child_process:289:12)
    at onErrorNT (node:internal/child_process:478:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn rsync',
  path: 'rsync',
@zallesov
Copy link

Having the same issue. Ended up here too. 👍 to boost the issue.

@Stradivario
Copy link
Member

Hi guys @zallesov @calclavia

I have introduced a PR which should resolve this problem.

#57

Executing command firelink --use-native-copy will use native nodejs implementation for recursive copy folders and files.

Please give it a shot by installing latest firelink and tell me how it goes.

npm install @rxdi/[email protected]

Cheers!

@Stradivario
Copy link
Member

Was thinking recently that i will make a fallback if rsync is not available to use native implementation so you don't need to provide additional argument.

Cheers

@Stradivario
Copy link
Member

Closing this due to inactivity please feel free to open it if this issue persists

@zallesov
Copy link

zallesov commented Feb 6, 2023

@Stradivario Looks like in version 0.9.x you removed this flag --use-native-copy and did not add a fallback to native. What is the solution than?

@Stradivario
Copy link
Member

Stradivario commented Feb 6, 2023

Interesting i didn't remove it let me check what is going on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants