From 23ddcb265da16e6db62b0b7d719715a2856dc69d Mon Sep 17 00:00:00 2001 From: decodism Date: Fri, 24 Feb 2023 23:44:31 +0100 Subject: [PATCH 1/2] Fix initial Todo shortcuts display --- Rectangle/AppDelegate.swift | 21 +- Rectangle/Base.lproj/Main.storyboard | 290 +++++++++--------- .../PrefsWindow/SettingsViewController.swift | 15 +- Rectangle/TodoMode/TodoManager.swift | 83 +++-- 4 files changed, 232 insertions(+), 177 deletions(-) diff --git a/Rectangle/AppDelegate.swift b/Rectangle/AppDelegate.swift index 19bc273ee..09786de26 100644 --- a/Rectangle/AppDelegate.swift +++ b/Rectangle/AppDelegate.swift @@ -398,12 +398,9 @@ extension AppDelegate: NSMenuDelegate { extension AppDelegate { func initializeTodo(_ bringToFront: Bool = true) { self.showHideTodoMenuItems() - guard Defaults.todo.userEnabled else { return } - TodoManager.registerToggleShortcut() - TodoManager.registerReflowShortcut() - if Defaults.todoMode.enabled { - TodoManager.moveAll(bringToFront) - } + TodoManager.registerUnregisterToggleShortcut() + TodoManager.registerUnregisterReflowShortcut() + TodoManager.moveAllIfNeeded(bringToFront) } enum TodoItem { @@ -459,19 +456,13 @@ extension AppDelegate { } @objc func toggleTodoMode(_ sender: NSMenuItem) { - if sender.state == .off { - Defaults.todoMode.enabled = true - TodoManager.moveAll() - } else { - Defaults.todoMode.enabled = false - } + let enabled = sender.state == .off + TodoManager.setTodoMode(enabled) } @objc func setTodoApp(_ sender: NSMenuItem) { applicationToggle.setTodoApp() - if Defaults.todoMode.enabled { - TodoManager.moveAll() - } + TodoManager.moveAllIfNeeded() } @objc func todoReflow(_ sender: NSMenuItem) { diff --git a/Rectangle/Base.lproj/Main.storyboard b/Rectangle/Base.lproj/Main.storyboard index 0ef5fd30a..ae391f350 100644 --- a/Rectangle/Base.lproj/Main.storyboard +++ b/Rectangle/Base.lproj/Main.storyboard @@ -2568,15 +2568,15 @@ - - + + - + - + - + @@ -2631,7 +2631,7 @@ - + - + - +