Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links don't work in Preview Coverage Report #250

Closed
geraintwhite opened this issue Jan 17, 2020 · 2 comments · Fixed by #363
Closed

Links don't work in Preview Coverage Report #250

geraintwhite opened this issue Jan 17, 2020 · 2 comments · Fixed by #363

Comments

@geraintwhite
Copy link

Describe the bug
None of the links to files work in the Preview Coverage Report

To Reproduce
Steps to reproduce the behaviour:

  1. Run 'Preview Coverage Report' from command palette
  2. Click on one of the file links
  3. Nothing happens

Expected behaviour
As when viewing the coverage report in the browser, clicking the link should display the coverage report for that file

Screenshots
image

Desktop (please complete the following information):

  • OS: macos
  • Extension Version 2.4.2
  • VSCode Version 1.41.1
@ryanluker
Copy link
Owner

ryanluker commented Jan 26, 2020

@grit96 Thanks for submitting an issue!
There is a bit of complexity here given the security Microsoft has put into the webview api for vscode extensions https://code.visualstudio.com/api/extension-guides/webview#loading-local-content . By default not many urls and resources are available to navigate between (I can see the expected errors when I open my debugger on a coverage report).

Screenshot from 2020-01-26 11-01-43

It is odd that the local workspace files are not exempt given that the docs say they are by default... Might be something to look into around anchor links that are generated by the coverage report tooling.

If someone wants to investigate this further, take a look at the WebviewOptions and start passing in something other then defaults to the webview panel create 🤔
https://github.com/ryanluker/vscode-coverage-gutters/blob/master/src/extension/gutters.ts#L58-L68

@ryanluker
Copy link
Owner

Fixed with #363 and will go out into the next release.

@ryanluker ryanluker modified the milestones: 3.0.0, 2.10.0 May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants