-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iosevka font glyphs broken #754
Comments
Glyphs
Did not find this earth with moon ;) glyph All glyphs in font are correct (wider than one advance width (500), because this is the non-mono font):
Although they are in an 'Ambiguous' range (https://github.com/microsoft/terminal/blob/main/src/types/CodepointWidthDetector.cpp#L246) Terminal rescales the glyphs as one-width. I do not want to additionally also dive into Terminal's code :-( and why it thinks some glyphs have to be scaled down. |
Will be fixed by a combination of
Maybe we should have a dedicated Issue for 'need non-mono with mono advance' (i.e. And |
Forgot the image: Created in this way:
diff --git a/font-patcher b/font-patcher
index f9c17689..c73337cd 100755
--- a/font-patcher
+++ b/font-patcher
@@ -817,11 +817,11 @@ class font_patcher:
# also ensures the font is considered monospaced on Windows by setting the
# same width for all character glyphs. This needs to be done for all glyphs,
# even the ones that are empty and didn't go through the scaling operations.
- self.set_glyph_width_mono(self.sourceFont[currentSourceFontGlyph])
# Ensure after horizontal adjustments and centering that the glyph
# does not overlap the bearings (edges)
self.remove_glyph_neg_bearings(self.sourceFont[currentSourceFontGlyph])
+ self.set_glyph_width_mono(self.sourceFont[currentSourceFontGlyph])
# end for
|
So the problem is in the windows terminal, not nerd fonts. Right? |
I tested patching with this branch and still got the same result. Maybe I'm missing something |
The branch and additionaly edit |
i.e. move the line with |
Worked like a charm. Thank you so much for your help. |
I reopen this, because - although it is fixed for you - it is not in general, and I wanted to create a MR ;) |
I guess #694 is your issues. I fixed the bug in |
Eiter this or I am just fine with it :) Sidenote: Maybe you can edit your script slightly so that it automaticly overwrites or not already existing fonts (PS Script for windows) |
Please raise a (new) feature request / issue about the PS script; here it will be lost. |
@kaykhancheckpoint |
Facing the issue with latest 2.2 iosevka drop. |
Could you provide a screenshot? Which of the many Iosevkas do you use? Which version? 2.2.1? |
See #898 I do not know how Nerd Fonts should proceed here. |
Thanks for quick update. Yes, looks like option 3 mentioned there would be needed for terminal. As there is a term variant of the font, can that variant use option 3? |
Also, as there are varied requirements, maybe it would be better if there can be reference to patcher command line to be used for each of the use cases/terminals. Then we can easily patch the fonts as per need. |
Ah, a good idea to make that a command line switch for |
Implemented in |
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
🎯 Subject of the issue
I just downloaded Iosevka from the patched-fonts folder and I'm getting this weird glyph size. It's like they scaled incorrectly. It looks to me as if they were monospaced but without being centered. I'm trying to use the non-mono version, so I'm expecting glyphs to have double width.
🔧 Your Setup
Iosevka Nerd Font Complete Windows Compatible.ttf
)_★ Screenshots (Optional)
The text was updated successfully, but these errors were encountered: