Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Please update Basic Usage documentation #159

Open
danielkwinsor opened this issue Dec 16, 2015 · 0 comments
Open

Please update Basic Usage documentation #159

danielkwinsor opened this issue Dec 16, 2015 · 0 comments

Comments

@danielkwinsor
Copy link

Exception is :org.springframework.beans.factory.xml.XmlBeanDefinitionStoreException: Line 27 in XML document from URL [jar:file:/redacted.jar!/config/spring/metrics-context.xml] is invalid; nested exception is org.xml.sax.SAXParseException: The string "--" is not permitted within comments.

metrics-context.xml is copied from the README.md and the mistaken line is <!-- Example reporter definiton. Supported reporters include jmx, slf4j, graphite, and others.

Further, I had a hard time getting things to work. I was transitioning from full usage of metrics-core/metrics-servlet, where I specified in web.xml the listeners and AdminServlet. The same attempt with metrics-spring did not work, because I did not realize codahale's AdminServlet was not getting the spring beans because it wasn't a Spring servlet. I was still trying to make AdminServlet work with MetricsServletsContextListener and ContextLoaderListener and etc, but that was the wrong approach entirely. So some clarity on how to use this with web.xml would be nice for later users. I'm ok now, using a full on DispatcherServlet and ContextLoaderListener setup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant