Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropType validation for type #206

Closed
zigzhang opened this issue Jul 21, 2018 · 2 comments
Closed

PropType validation for type #206

zigzhang opened this issue Jul 21, 2018 · 2 comments
Labels
enhancement

Comments

@zigzhang
Copy link

zigzhang commented Jul 21, 2018 •
edited
Loading

Thanks for the great work! The Component is working really well for us.
We are using NumberFormat with a type="password" (for users to fill sensitive information), but we have a PropType error Invalid prop typeof valuepasswordsupplied toNumberFormat, expected one of ["text","tel"].

It's actually working pretty well with type="password". Could you add this type in the PropType validation? It's definitely not a blocker, but you know... :)
@s-yadav
Copy link
Owner

s-yadav commented Sep 19, 2018

I will add this

@s-yadav s-yadav mentioned this issue Oct 1, 2018
Closed
6 tasks
@s-yadav
Copy link
Owner

s-yadav commented Oct 30, 2018

Added on v4.

@s-yadav s-yadav closed this as completed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s-yadav @zigzhang