-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add flexibility to get other props as a part of renderText function #484
feat: Add flexibility to get other props as a part of renderText function #484
Conversation
- Update build files
@naman03malhotra @ParthS007, CI not working on PRs, can anyone take a look into this. |
I can make PR. @naman03malhotra Please let me know if you have already started working on this. |
@ParthS007, Merged your changes. The action seems working correctly now. |
@s-yadav Ready for review 😄 |
@nikhil-varma Can you please rebase your branch with the latest master for CI to run. Thanks |
@ParthS007 Done! 😄 |
@s-yadav Can you please verify if the changes are good to go! 😄 |
LGTM, can you add spec for the change. |
@s-yadav Specs are added. Please review if it looks good! Thanks! |
@s-yadav Should we go ahead and close the linked issue? Or wait until we release the new patch/version and then do it? What is the convention that we follow? |
Will release a new version. |
@s-yadav Right! I will update the readme and create a PR for this. |
Describe the issue/change
In the current system, we cannot get access to the custom props that are passed in the
renderText
method.Add CodeSandbox link to illustrate the issue (If applicable)
Describe the changes proposed/implemented in this PR
This PR introduces another parameter in the
renderText
method in order to get the props passed to the componentLink Github issue if this PR solved an existing issue
Issue: #456
Example usage (If applicable)
Screenshot (If applicable)
Please check which browsers were used for testing