-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max_id_range
CVar
#725
Conversation
Need to handle this CVar with negative value too. I can't imagine a useful scenario for this change. It might be better to make it possible to control the distance through the API, but not the CVar. |
Default value does not allow showing nickname on big maps, like de_abaddon. |
In this case, wouldn't it be better to use the |
Could you please open an issue for that for better tracking? (a screenshot(s) and/or a video would be a good addition) |
Sure |
Maybe so. But I think that some pople can wants to keep default behavoir? |
Might also relies on CVar "sv_zmax" instead of making a new one. |
@s1lentq, @StevenKal, ok, I agree with you. I'll open another PR if I can. |
Was no need to close it, if you O.K. to use zmax, just update it with pointer of CVar "sv_zmax" (add a global "g_psv_zmax" in "game.<cpp|h>" files to get the pointer & replace "max_id_range.value" by "g_psv_zmax->value" or more safe by "(g_psv_zmax ? g_psv_zmax->value : 2048)")! |
This CVar allows you to define your own range to show player's nickname.
related to: #726