Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_id_range CVar #725

Closed
wants to merge 3 commits into from

Conversation

Nord1cWarr1or
Copy link
Contributor

@Nord1cWarr1or Nord1cWarr1or commented Feb 6, 2022

This CVar allows you to define your own range to show player's nickname.

related to: #726

@SergeyShorokhov
Copy link
Member

SergeyShorokhov commented Feb 6, 2022

Need to handle this CVar with negative value too.

I can't imagine a useful scenario for this change. It might be better to make it possible to control the distance through the API, but not the CVar.

@Nord1cWarr1or
Copy link
Contributor Author

I can't imagine a useful scenario for this change. It might be better to make it possible to control the distance through the API, but not the CVar.

Default value does not allow showing nickname on big maps, like de_abaddon.

@s1lentq
Copy link
Collaborator

s1lentq commented Feb 6, 2022

I can't imagine a useful scenario for this change. It might be better to make it possible to control the distance through the API, but not the CVar.

Default value does not allow showing nickname on big maps, like de_abaddon.

In this case, wouldn't it be better to use the MaxRange map value?

@WPMGPRoSToTeMa
Copy link
Contributor

WPMGPRoSToTeMa commented Feb 6, 2022

Default value does not allow showing nickname on big maps, like de_abaddon.

Could you please open an issue for that for better tracking? (a screenshot(s) and/or a video would be a good addition)

@Nord1cWarr1or
Copy link
Contributor Author

Default value does not allow showing nickname on big maps, like de_abaddon.

Could you please open an issue for that for better tracking? (a screenshot(s) and/or a video would be a good addition)

Sure

@Nord1cWarr1or
Copy link
Contributor Author

Nord1cWarr1or commented Feb 6, 2022

In this case, wouldn't it be better to use the MaxRange map value?

Maybe so. But I think that some pople can wants to keep default behavoir?

@StevenKal
Copy link
Contributor

StevenKal commented Feb 7, 2022

Might also relies on CVar "sv_zmax" instead of making a new one.
So in such case the maximum player visibility could be linked to the max "map visibility".
A new CVar allows customization, so it is always better, but I do not see much the point to customize that kind of stuff to a lower value (like 500 units).
And another name for the CVar with a common prefix might be preferable (like "mp_playerid_range_max", something like). But using "mp" prefix for this is discutable.

@Nord1cWarr1or
Copy link
Contributor Author

@s1lentq, @StevenKal, ok, I agree with you. I'll open another PR if I can.

@StevenKal
Copy link
Contributor

StevenKal commented Feb 10, 2022

Was no need to close it, if you O.K. to use zmax, just update it with pointer of CVar "sv_zmax" (add a global "g_psv_zmax" in "game.<cpp|h>" files to get the pointer & replace "max_id_range.value" by "g_psv_zmax->value" or more safe by "(g_psv_zmax ? g_psv_zmax->value : 2048)")!
Then remove the other parts not needed in other files.

@Nord1cWarr1or Nord1cWarr1or deleted the max-id-range-cvar branch October 29, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants