-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import and Annotate on PDFs directly #429
Comments
That functionality already exists, unless you are talking about saving the annotations made by saving it on the PDF, or by exporting it to a PDF |
As far as I can figure out it is only possible to import a PDF into a note and show the PDF pages on a note. However, I am talking about not importing it into a note. So, showing the PDF without a "page" background and editing the PDF. |
Maybe related to #277 |
Is it related to the grid lines showing in ur PDF similar to #400 ? |
I do not mean editing PDFs per se like in #277. Rather I am talking about not importing the PDF and scaling it to a note, but importing the PDF, not scaling it to a note, and annotating on it. I am aware, that not setting it as a background image does not scale it. Then, however, it is small and shown on a page of a note. Is it understandable what I am talking about? |
I am not 100% sure what u are saying. Are u talking about editing PDFs like u do it in Adobe Acrobat? |
No, let me try to explain in detail. So, when importing a PDF (e.g. of size A4) to saber it automatically sets it as a background, and also scales it to fit the page. As a result, the resolution becomes less clear. The other option is not selecting the PDF as a background. Then, the resolution is clear, but the PDF is smaller than the page. If I open the PDF in e.g. "Secure PDF Viewer" from GrapheneOS, then the PDF shows high resolution and fits on one page. Now, take a PDF of different size (not A4, but any other size), then the scaling also happens. If it is not scaled, then it is shown on a page of the note. What I want is the PDF not scaled in any way such that the resolution stays the original, and also not showing it on a page (just show the PDF, not on a page of a note), and be able to edit it. Is it clearer now, what I mean? I could try to provide some screenshots as well! |
So ur main concern is the resolution? smth like #400 (comment) ? |
So, does adding another page size solve your problem? |
My main concern is the resolution when the pdf is scaled to fit on the page, and showing the white page when the pdf is not scaled to fit on the page. I am going to post screenshots now. |
So to understand your use case, you want to:
Am I getting this right? Forget the Background Image thing for a bit |
Actuallry, you could even skip point 1. So,
|
Well to make it easier to implement and intuitive for ppl, u do need step 1 Your issue can be divided into 2 parts:
Is this correct? |
Yes, this is correct. However, I think it is important that the PDF is not always scaled to A4, e.g. if some pages of a PDF have a different format, just to keep in mind. Thank you for your patience!! |
Sure, I can later open separate issues for whatever is mentioned above. You can close this issue for now, as one of ur issue mentioned is a known issue, while the other is an enhancement. Yes, I think we can think of a way to dynamically set page sizes according to the PDF |
Thank you very much for your help! Just to let you know I am enjoying Saber very much! |
It would be amazing if it was possible to import a PDF into Saber and annotate directly on it. In more detail, importing not into a note with the PDF being displayed on a page, but importing the PDF without showing it on a page and annotate on it.
The text was updated successfully, but these errors were encountered: