Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import and Annotate on PDFs directly #429

Closed
m0byn opened this issue Mar 1, 2023 · 17 comments
Closed

Import and Annotate on PDFs directly #429

m0byn opened this issue Mar 1, 2023 · 17 comments
Labels
enhancement New feature or request

Comments

@m0byn
Copy link

m0byn commented Mar 1, 2023

It would be amazing if it was possible to import a PDF into Saber and annotate directly on it. In more detail, importing not into a note with the PDF being displayed on a page, but importing the PDF without showing it on a page and annotate on it.

@m0byn m0byn added the enhancement New feature or request label Mar 1, 2023
@WasteOfO2
Copy link

That functionality already exists, unless you are talking about saving the annotations made by saving it on the PDF, or by exporting it to a PDF

@m0byn
Copy link
Author

m0byn commented Mar 1, 2023

As far as I can figure out it is only possible to import a PDF into a note and show the PDF pages on a note. However, I am talking about not importing it into a note. So, showing the PDF without a "page" background and editing the PDF.

@ghost
Copy link

ghost commented Mar 1, 2023

Maybe related to #277

@WasteOfO2
Copy link

Is it related to the grid lines showing in ur PDF similar to #400 ?

@m0byn
Copy link
Author

m0byn commented Mar 1, 2023

I do not mean editing PDFs per se like in #277. Rather I am talking about not importing the PDF and scaling it to a note, but importing the PDF, not scaling it to a note, and annotating on it. I am aware, that not setting it as a background image does not scale it. Then, however, it is small and shown on a page of a note. Is it understandable what I am talking about?

@WasteOfO2
Copy link

I am not 100% sure what u are saying.

Are u talking about editing PDFs like u do it in Adobe Acrobat?

@m0byn
Copy link
Author

m0byn commented Mar 1, 2023

No, let me try to explain in detail. So, when importing a PDF (e.g. of size A4) to saber it automatically sets it as a background, and also scales it to fit the page. As a result, the resolution becomes less clear. The other option is not selecting the PDF as a background. Then, the resolution is clear, but the PDF is smaller than the page. If I open the PDF in e.g. "Secure PDF Viewer" from GrapheneOS, then the PDF shows high resolution and fits on one page. Now, take a PDF of different size (not A4, but any other size), then the scaling also happens. If it is not scaled, then it is shown on a page of the note. What I want is the PDF not scaled in any way such that the resolution stays the original, and also not showing it on a page (just show the PDF, not on a page of a note), and be able to edit it.

Is it clearer now, what I mean? I could try to provide some screenshots as well!

@WasteOfO2
Copy link

WasteOfO2 commented Mar 1, 2023

So ur main concern is the resolution?

smth like #400 (comment) ?

@ghost
Copy link

ghost commented Mar 1, 2023

So, does adding another page size solve your problem?

@m0byn
Copy link
Author

m0byn commented Mar 1, 2023

My main concern is the resolution when the pdf is scaled to fit on the page, and showing the white page when the pdf is not scaled to fit on the page. I am going to post screenshots now.

@m0byn
Copy link
Author

m0byn commented Mar 1, 2023

This is how it looks like when setting as background.
Screenshot_20230301-133519

The resolution is not that good.
This is how it looks like when not setting as background.
Screenshot_20230301-133719

It shows the rest of the page of the note.

This is how it looks like in Secure PDF Viewer.
Screenshot_20230301-133735_PDF Viewer

Scaled and good resolution and no rest of page showing. The grey stuff around is the background of the app, but it is invisivble when saving the document...

The reason why I opened the issue is, that I have to annotate many PDF files and send them back to the people I got them from. I do not want to send them back in a worse resolution or showing the rest of the pages of the note...

My idea would be instead of embedding the PDFs in a note/on pages of a note, it would be a very nice feature if it was possible to open the PDF, annotate it, and not embed it in a note where it is either scaled (worse resolution), or not scaled (rest of page of note shown), but just access the pages of the PDF without the note framework...

@WasteOfO2
Copy link

WasteOfO2 commented Mar 1, 2023

So to understand your use case, you want to:

  1. Create a note
  2. Import the original PDF with good resolution
  3. Make annotations on your PDF
  4. Update the PDF with annotations with good resolution
  5. Send the updated PDF to whoever you want

Am I getting this right? Forget the Background Image thing for a bit

@m0byn
Copy link
Author

m0byn commented Mar 1, 2023

Actuallry, you could even skip point 1. So,

  1. Import the original PDF with good resolution
  2. Make annotations on your PDF
  3. Send the imported PDF to whoever you want

@WasteOfO2
Copy link

WasteOfO2 commented Mar 1, 2023

Actuallry, you could even skip point 1. So,

1. Import the original PDF with good resolution

2. Make annotations on your PDF

3. Send the imported PDF to whoever you want

Well to make it easier to implement and intuitive for ppl, u do need step 1

Your issue can be divided into 2 parts:

  1. The poor resolution on importing PDFs (confirmed in Weird PDF appearance in Dark Mode #400 (comment))

  2. The ability to save the PDF with annotations and send them (aka export notes as a PDF)

Is this correct?

@m0byn
Copy link
Author

m0byn commented Mar 1, 2023

Yes, this is correct. However, I think it is important that the PDF is not always scaled to A4, e.g. if some pages of a PDF have a different format, just to keep in mind.

Thank you for your patience!!

@WasteOfO2
Copy link

Sure, I can later open separate issues for whatever is mentioned above.

You can close this issue for now, as one of ur issue mentioned is a known issue, while the other is an enhancement.

Yes, I think we can think of a way to dynamically set page sizes according to the PDF

@m0byn
Copy link
Author

m0byn commented Mar 1, 2023

Thank you very much for your help! Just to let you know I am enjoying Saber very much!

@m0byn m0byn closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants