Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize immutable variables #699

Closed
PaulRBerg opened this issue Oct 2, 2023 · 0 comments · Fixed by #700
Closed

Capitalize immutable variables #699

PaulRBerg opened this issue Oct 2, 2023 · 0 comments · Fixed by #700
Assignees

Comments

@PaulRBerg
Copy link
Member

Immutable variables are constant at runtime, so they should be named like constants in UPPERCASE_SNAKE_CASE.

Solhint has a rule for this, which is currently disabled in our Solhint config file. Activating it finds several occurrences:

https://app.warp.dev/block/782axtYGfdaPdIxf8mHIAY

We should refactor and then activate the rule (by removing this line from the Solhint config).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants