Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flash loans #733

Closed
PaulRBerg opened this issue Dec 4, 2023 · 2 comments
Closed

Remove flash loans #733

PaulRBerg opened this issue Dec 4, 2023 · 2 comments
Assignees
Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: refactor Change that neither fixes a bug nor adds a feature. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Member

In light of:

  1. Our recent decision to remove the proxy targets from V2 Periphery
  2. The fact that implementing them would be a faff
  3. The fact that they would act as a deterrent for vesting users
  4. The reality that we have many other priorities

We should remove the flash loan logic from this repository; it increases the maintenance cost without adding any value.

@PaulRBerg PaulRBerg added this to the V2.2 milestone Dec 4, 2023
@andreivladbrg
Copy link
Member

We should remove the flash loan logic from this repository;

does it mean that we should also change the comptroller contract?

/// @inheritdoc ISablierV2Comptroller
UD60x18 public override flashFee;
/// @inheritdoc ISablierV2Comptroller
mapping(IERC20 asset => bool supported) public override isFlashAsset;

@PaulRBerg
Copy link
Member Author

Yep.

Let's schedule this for V2.2

@smol-ninja smol-ninja self-assigned this Dec 15, 2023
@PaulRBerg PaulRBerg added effort: high Large or difficult task. type: refactor Change that neither fixes a bug nor adds a feature. priority: 1 This is important. It should be dealt with shortly. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. and removed backlog labels Jan 1, 2024
@andreivladbrg andreivladbrg moved this to 📋 Not Started in Lockup 1.2.0 Jan 4, 2024
@smol-ninja smol-ninja moved this from 📋 Not Started to 👀 In review in Lockup 1.2.0 Jan 4, 2024
@smol-ninja smol-ninja removed their assignment Jan 4, 2024
@PaulRBerg PaulRBerg removed this from the V2.2 milestone Jan 4, 2024
@smol-ninja smol-ninja moved this from 👀 In review to ✅ Done in Lockup 1.2.0 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: refactor Change that neither fixes a bug nor adds a feature. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants