Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single test default used for two different constants #870

Closed
PaulRBerg opened this issue Mar 29, 2024 · 0 comments
Closed

Single test default used for two different constants #870

PaulRBerg opened this issue Mar 29, 2024 · 0 comments
Assignees
@PaulRBerg
Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Member

The MAX_COUNT default is used for both MAX_SEGMENT_COUNT and MAX_TRANCHE_COUNT:

https://github.com/sablier-labs/v2-core/blob/e080f20eafef0fc18049bcc77f1694db043860f1/test/utils/Defaults.sol#L26

This is not good because there can be more tranches than segments (as discussed here).

We should have two different defaults.
@PaulRBerg PaulRBerg added priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. effort: low Easy or tiny task that takes less than a day. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Mar 29, 2024
@PaulRBerg PaulRBerg self-assigned this Mar 29, 2024
@PaulRBerg PaulRBerg mentioned this issue Mar 29, 2024
Closed
@PaulRBerg PaulRBerg mentioned this issue Apr 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulRBerg PaulRBerg

Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smol-ninja @PaulRBerg