Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply "named-parameters-function" Solhint rule #150

Closed
PaulRBerg opened this issue Jul 15, 2023 · 3 comments
Closed

Apply "named-parameters-function" Solhint rule #150

PaulRBerg opened this issue Jul 15, 2023 · 3 comments
Labels
effort: low Easy or tiny task that takes less than a day. good first issue Good for newcomers. priority: 3 Nice-to-have. Willing to ship without this. type: style Changes that do not affect the meaning of the code. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Member

Context:
@PaulRBerg PaulRBerg mentioned this issue Jul 15, 2023
Merged
@PaulRBerg PaulRBerg added good first issue Good for newcomers. effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: style Changes that do not affect the meaning of the code. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. and removed testing labels Jan 1, 2024
@smol-ninja
Copy link
Member

Since we decided to remove solhint-community in f975c09, should we close this issue since named-parameters-function rule does not exist in solhint?

@smol-ninja
Copy link
Member

Bumping this up to follow up on my previous comment.

@PaulRBerg
Copy link
Member Author

Sorry, I missed the previous comment.

Yeah we can close this.

@PaulRBerg PaulRBerg closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low Easy or tiny task that takes less than a day. good first issue Good for newcomers. priority: 3 Nice-to-have. Willing to ship without this. type: style Changes that do not affect the meaning of the code. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smol-ninja @PaulRBerg