Add parameter to generate vanity addresses #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
changed the title
Uxio0
force-pushed
the
vanity-addresses
branch
from
73096cd to
16eded0
Compare
moisses89
reviewed
Jan 29, 2025
src/safe_cli/safe_creator.py
Outdated
| Example: | ||
| safe-creator https://sepolia.drpc.org 0000000000000000000000000000000000000000000000000000000000000000 | ||
| """ | ||
|
|
||
|
|
||
| def setup_argument_parser(): | ||
| parser = argparse.ArgumentParser(usage=get_usage_msg()) | ||
| parser = argparse.ArgumentParser(description=get_epilog_msg()) | ||
| # parser = argparse.ArgumentParser(usage=get_usage_msg()) |
There was a problem hiding this comment.
Why don't remove this line?
src/safe_cli/safe_creator.py
Outdated
| sys.exit(1) | ||
|
|
||
| if yes_or_no( | ||
| f"Safe will be deployed on {expected_safe_address}, looks good?" |
There was a problem hiding this comment.
Suggested change
| f"Safe will be deployed on {expected_safe_address}, looks good?" | |
| f"Safe will be deployed on {expected_safe_address}. Would you like to proceed?" |
There was a problem hiding this comment.
This has been here forever, but looks good 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-confirmto bypassyes or noquestions--generate-vanity-addressesfor vanity addresses--dry-run&--quietArguments for Testing Vanity Safe Addresses #457