Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated stuff from tickets 22*** #29144

Closed
fchapoton opened this issue Feb 2, 2020 · 10 comments
Closed

remove deprecated stuff from tickets 22*** #29144

fchapoton opened this issue Feb 2, 2020 · 10 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.1

Comments

@fchapoton
Copy link
Contributor

namely #22626, #22955, #22907

CC: @tscrim @jm58660

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 2165419

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29144
@fchapoton fchapoton added this to the sage-9.1 milestone Feb 2, 2020
@fchapoton

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor Author

New commits:

31cf181removed deprecated stuff from 22626, 22955 and 22907

@fchapoton
Copy link
Contributor Author

Commit: 31cf181

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/29144

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 2, 2020

Changed commit from 31cf181 to 2165419

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 2, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

2165419fix

@fchapoton
Copy link
Contributor Author

comment:3

bot is morally green, please review

@tscrim
Copy link
Collaborator

tscrim commented Feb 3, 2020

comment:4

LGTM. Actually, now we can lazily construct the basis for a matrix space I think.

@tscrim
Copy link
Collaborator

tscrim commented Feb 3, 2020

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Feb 11, 2020

Changed branch from u/chapoton/29144 to 2165419

@vbraun vbraun closed this as completed in 74c9134 Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton